[Bug 495564] Review Request: libguestfs - Access and modify virtual machine disk images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495564





--- Comment #11 from Jim Meyering <meyering at redhat.com>  2009-05-06 08:12:14 EDT ---
Hi Rich,

In src/guestfs.c, you probably want to use a read wrapper
so you don't have to worry about EINTR and EAGAIN
(the code should retry, not fail in those cases).
It looks like there are a few others that would benefit.

  while (!cancel && (r = read (fd, buf, sizeof buf)) > 0) {
    err = send_file_data_sync (g, buf, r);
    if (err < 0) {
      if (err == -2)  /* daemon sent cancellation */
 send_file_cancellation_sync (g);
      return err;
    }
  }

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.