[Bug 497947] Review Request: libmetalink - A Metalink C library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497947





--- Comment #6 from Ant Bryan <anthonybryan at gmail.com>  2009-05-06 13:49:10 EDT ---
(In reply to comment #3)
> A few notes:
> 
> - .la files need to be removed, add
>  find . -name *.la -exec rm {} \;
> to the end of the install phase
> 
> - if possible, static library build should be disable (usually %configure
> --disable-static)
> 
> - devel package needs to Requires: pkgconfig
> 
> - you're running autoreconf, but not BRing the packages => the package will not
> build in mock. Autoreconf'ing is frowned upon, and should not be done unless it
> is specifically necessary.  

I may not have been clear before, but I addressed those 4 issues you found and
they are resolved in my second round of rpms.

Spec URL: http://pastebin.ca/1407423
SRPM URL:
http://www.metalinker.org/mirrors/libmetalink/libmetalink-0.0.3-2.fc10.src.rpm

Any other issues I can fix?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.