[Bug 497947] Review Request: libmetalink - A Metalink C library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497947





--- Comment #10 from Ant Bryan <anthonybryan at gmail.com>  2009-05-06 19:44:39 EDT ---
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)> And you have to own the directory /usr/include/metalink  
> > 
> > %files
> > %dir /usr/include/metalink
> 
> A lot neater is to
> 
> %files devel
> %defattr(-,root,root,-)
> %{_includedir}/metalink/

Thank you, I'll go with your neater solution :)

> Also, according to your files listing there is still a static library in the
> devel package; you either have to exclude it from the package or make the devel
> package provide libmetalink-static = %{version}-%{release}  

I added this to the devel package:

Provides:      libmetalink-static = %{version}-%{release}

but the same files are included in the devel package.

libmetalink-devel-0.0.3-3.fc10.i386.rpm :
drwxr-xr-x  /usr/include/metalink
-rw-r--r--  /usr/include/metalink/metalink_error.h
-rw-r--r--  /usr/include/metalink/metalink_parser.h
-rw-r--r--  /usr/include/metalink/metalink_types.h
-rwxr-xr-x  /usr/lib/libmetalink.la
lrwxrwxrwx  /usr/lib/libmetalink.so
-rw-r--r--  /usr/lib/pkgconfig/libmetalink.pc

Which is the static library in the devel package?

Which is better, excluding it from the package or making the devel package
provide libmetalink-static = %{version}-%{release} ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.