[Bug 499319] Review Request: tcl-snmptools - TCL extension for SNMP support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499319


Guido Grazioli <guido.grazioli at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |guido.grazioli at gmail.com




--- Comment #2 from Guido Grazioli <guido.grazioli at gmail.com>  2009-05-07 19:30:51 EDT ---
Hi Bryson, this is just an informal review, because i'm not a sponsored
reviewer yet.

OK - rpmlint
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
OK - The package must be named according to the  Package Naming Guidelines.
OK - The spec file name must match the base package %{name}

NEEDSWORK - The package must meet the Packaging Guidelines
- use %global instead of %define

NEEDSWORK - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc
- include the file license.terms in %doc

NEEDSWORK - The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines
- some files are under CMU license (BSD like), fix the License tag

NEEDSWORK - Every binary RPM package which stores shared library files must
call ldconfig in %post and %postun 
- add ldconfig calls

OK - The package MUST successfully compile and build
koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1342406
OK - The spec file must be written in American English.
OK - The spec file for the package MUST be legible.
OK - The sources used to build the package must match the upstream source, as
provided in the spec URL. 
ddbd09e2e39e2efa4155981317ec5394  tcl-snmptools-1.0.tar.gz
NA - The spec file MUST handle locales properly (no translations)
NA - package not relocatable
OK - A package must own all directories that it creates
OK - A Fedora package must not list a file more than once in the spec file's
%files listings
OK - Permissions on files must be set properly
OK - Each package must have a %clean section
OK - Each package must consistently use macros
OK - The package must contain code, or permissable content (no content)
NA - Large documentation files must go in a -doc subpackage (no large doc)
OK - If a package includes something as %doc, it must not affect the runtime of
the application
NA - Header files must be in a -devel package (no devel package)
NA - Static libraries must be in a -static package (no static package)
NA - Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
OK - Packages must NOT contain any .la libtool archives
NA - Packages containing GUI applications must include a .desktop file (no gui)
OK - At the beginning of %install, each package MUST run rm -rf %{buildroot}
OK - All filenames in rpm packages must be valid UTF-8

Hope that helps, regards

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.