[Bug 499409] Review Request: jargs - Java command line option parsing suite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499409





--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-05-09 06:07:40 EDT ---
- http://fedoraproject.org/wiki/Packaging/Java states as minimum BR:s and
Requires:
 BuildRequires: java-devel [>= specific_version] 
 BuildRequires:  jpackage-utils
 Requires:  java >= specific_version
 Requires:  jpackage-utils

- You can probably drop BR: libgcj after adding the above.

- Have a look at the spec file template for ant at
 http://fedoraproject.org/wiki/Packaging/Java#ant_2

- Remove any preexisting jar files in the %setup phase with
 find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;
(this in order to make sure that everything is built from source).

- When installing, use "-p" to preserve time stamps.

- jar file must have same name as package:
http://fedoraproject.org/wiki/Packaging/Java#Jar_file_naming
(drop the symlinking and just install %{name}.jar in %_javadir)

- Same goes with javadocdir, don't version it.

- Use %defattr(-,root,root,-) for javadoc package as well.


Once you have fixed these I will do the full review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.