[Bug 499409] Review Request: jargs - Java command line option parsing suite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499409





--- Comment #9 from Guido Grazioli <guido.grazioli at gmail.com>  2009-05-09 09:44:12 EDT ---
(In reply to comment #6)
- Source url is incorrect:
 http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
Also, you might want to use %{version} in the Source URL line, so that you
don't have to change the version in multiple locations (you might end up
building an old version).

ok

- I don't think the explicit Java version is necessary: 1.4.2 is quite old and
is found on every distribution.

ok (jarg will compile starting with java2 afterwards)


(In reply to comment #7)
> Package doesn't build in mock. You are missing
>  BuildRequires: junit
> after which it builds.  

That's weird i avoided building the junit tests; are you referring to the
warnings produced while building javadoc? (like here
http://koji.fedoraproject.org/koji/getfile?taskID=1338558&name=build.log )
If we cant ignore those warnings i will modify the spec to include the test jar
also.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.