[Bug 495949] Review Request: python-kinterbasdb - A Python DB-API 2.0 compliant interface to Firebird

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495949





--- Comment #12 from Peter Lemenkov <lemenkov at gmail.com>  2009-05-11 06:28:57 EDT ---
REVIEW:

+/- rpmlint is not silent:

[petro at Sulaco Desktop]$ rpmlint python-kinterbasdb-*
python-kinterbasdb.ppc: W: wrong-file-end-of-line-encoding
/usr/share/doc/python-kinterbasdb-3.3.0/README
python-kinterbasdb.src: W: mixed-use-of-spaces-and-tabs (spaces: line 15, tab:
line 5)
3 packages and 0 specfiles checked; 0 errors, 2 warnings.
[petro at Sulaco Desktop]$ 

The former warning must be fixed in %prep section. Just add the following line:
sed -i 's|\r||g' README

The latter warning may be ignored, but you should consider suppressing it as
well. Not a blocker.

+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.

- The package meets the Packaging Guidelines, except leftover in install
section. Please remove "%{__python} setup.py install --skip-build --root
$RPM_BUILD_ROOT" string. It duplicates by the following string and doesn't
explicitly contain -O1. 

Another one issue with this package is duplicated content - it contains
doc-files as %doc and inside the %{python_sitearch}/%{origname}/ . I advice you
to remove the doc-directory from %{python_sitearch}/%{origname}/ at the
%install stage (quick fix), or to patch setup.py (more proper way).

+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license (BSD)
+ The file, containing the text of the license(s) for the package, is included
in %doc (doc/license.html).
+ The spec file is written in American English.
+ The spec file for the package is legible (as almost all python packages -
thanks to distutils!)
+ The sources used to build the package matches the upstream source

[petro at Sulaco SOURCES]$ md5sum kinterbasdb-3.3.0.tar.bz2*
0296d2dbc7b76dac140b5fec2ad59f0e  kinterbasdb-3.3.0.tar.bz2
0296d2dbc7b76dac140b5fec2ad59f0e  kinterbasdb-3.3.0.tar.bz2.1
[petro at Sulaco SOURCES]$

+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1347344

+ All build dependencies are listed in BuildRequires.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
+ No extremely large documentation files.
+ Everything, the package includes as %doc, does not affect the runtime of the
application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.


Summary:

* Suppress rpmlint warning(s).
* Get rid of duplicated install attemts in the %install section.
* Remove docs from %{python_sitearch}/%{origname}/ or explain why it's
necessary to install them here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.