[Bug 499300] Review Request: zita-convolver - Convolution engine library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499300


Mattias Ellert <mattias.ellert at fysast.uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mattias.ellert at fysast.uu.se
               Flag|                            |fedora-review+




--- Comment #1 from Mattias Ellert <mattias.ellert at fysast.uu.se>  2009-05-11 08:54:37 EDT ---
fedora review zita-convolver-1.0.0-2.fc10.src.rpm 2009-05-11

* OK
! needs attention

* rpmlint output:

  zita-convolver-devel.x86_64: W: no-documentation
  4 packages and 1 specfiles checked; 0 errors, 1 warnings.

* Package is named according to the guidelines

* The specfile is named after the package

* The package is licensed under a Fedora approved license (GPLv2+)

* The license tag mayches the license information in the source

* The package includes the license file (COPYING)

* The specfile is written in legible English

* Source matches upstream and is latest version

  892ef99cf39b6a8e87639efdcd96dbd5  zita-convolver-1.0.0.tar.bz2
  892ef99cf39b6a8e87639efdcd96dbd5  SRPM/zita-convolver-1.0.0.tar.bz2

* Package builds in mock (Fedora 10)

* Build requires are sane

* Package calles ldconfig approproately

* The package owns the directories it creates

* No double listed files

* File permissions are sane and %files has %defattrs

* %clean clears buildroot

* The specfile uses macros consistently

* Package contains code

* %doc is not essential for running

* Package does not own other's directories

* %install clears buildroot

* Installed filenames are valid UTF-8


Package approved

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.