[Bug 500437] Review Request: cnetworkmanager - Command-line client for NetworkManager

bugzilla at redhat.com bugzilla at redhat.com
Tue May 12 18:57:26 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=500437





--- Comment #4 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-05-12 14:57:25 EDT ---
(In reply to comment #3)

> The build step is a single sed call. 
> I will add smp if you insist, but it really makes no sense at all. 
> 
> >- Please replace
> >
> >%{_sysconfdir}/dbus-1/system.d/cnetworkmanager.conf
> >%{_sysconfdir}/dbus-1/system.d/cnetworkmanager-06.conf
> >
> >%config(noreplace) %{_sysconfdir}/dbus-1/system.d/cnetworkmanager.conf
> >%config(noreplace) %{_sysconfdir}/dbus-1/system.d/cnetworkmanager-06.conf
> 
> I don't think these are supposed to be config files. 
> See gdm, NetworkManager, ConsoleKit, etc. None of them mark them as config. 
> Users should not be editing these. It's just a bug that they are under /etc/ I
> guess. 

I have done a look ok gdm and have to disagree with you. On gdm you see 
%config in fromt of the files which an in %{_sysconfigdir}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list