[Bug 491518] Review Request: openttd - Transport system simulation game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491518





--- Comment #10 from Alexey Torkhov <atorkhov at gmail.com>  2009-05-17 06:34:25 EDT ---
(In reply to comment #6)
> > - Would be good to generate AI docs from src/ai/api/Doxyfile and put them to
> > subpackage.
> > 
> 
> This IMHO makes no sense, this is an internal API, which is not exported
> so no need to buid or include the docs.

This is only script "external" API that is used by squirrel AI scripts. And it
could be used by AI writers as scripts are easily added as plugins.

> > - Macros issue in opengfx package is not addressed.  

Macro usage is not consistent there - it is mixing "rm" and %{__rm} there for
instance. I think, all macros like %{__rm} should be replaced in favour of
simple commands.

(In reply to comment #9)
> Ah I wasn't aware of this policy, glad I mist the flame fest one that one :)

Hehe.

> (In reply to comment #8)
> > (In reply to comment #6)
> > > As promised I will review this, but it looks like we first need to address
> > > the flags issue <sigh>, assigning to me.  
> > 
> > I'm thinking, that we can just hide language column with flags. If such
> > solution would be acceptable, I can come with a patch for it.  
> 
> Would there then still be a way for the user to find out the server language
> from the pick a server UI ?  

Yes, when user clicks on individual server line, server language will be shown
on server details panel. But in such, there won't be simple way to fast search
for particular language - user will have to click on each server if he wants to
find server where is that particular language spoken.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.