[Bug 499394] Review Request: ampache - web based audio/video streaming application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499394





--- Comment #10 from Paulo Roma Cavalcanti <promac at gmail.com>  2009-05-17 07:03:13 EDT ---
(In reply to comment #9)
> Several of your install commands don't use -p and thus don't preserve
> timestamps.

This can be done, but the files being installed are my own source.

> 
> Additionally, your cp commands don't consistently use the same parameters, and
> while technically correct, may be something you want to look out, though it's
> certainly not a blocker, more of a style issue if anything.

I used cp -a, which according to the manual, is the same as -cdpR

> 
> Why are you deleting the man page? You just copied the file there just a few
> lines earlier
> 

The man page would go to the doc directory (/usr/share/doc/ampache).
I just installed it in the appropriate place, /usr/share/man/man1/,
and removed it to avoid the same file being in two different places.
Furthermore, if I kept a copy in the doc dir, rpmlint would complain it
is not compressed. 

> [ke4qqq at nalleyt61 SPECS]$ rpmlint ./ampache.spec 
> 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
> [ke4qqq at nalleyt61 SPECS]$ rpmlint ../SRPMS/ampache-3.5-8.fc10.src.rpm 
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> [ke4qqq at nalleyt61 SPECS]$ rpmlint ../RPMS/noarch/ampache-3.5-8.fc10.noarch.rpm 
> ampache.noarch: E: non-executable-script
> /usr/share/ampache/locale/base/gather-messages.sh 0644
> ampache.noarch: W: non-standard-uid /var/log/ampache apache
> ampache.noarch: W: non-standard-gid /etc/ampache.cfg apache
> ampache.noarch: E: non-readable /etc/ampache.cfg 0640
> 1 packages and 0 specfiles checked; 2 errors, 2 warnings.
> 
> 
> 
> The modules directory contains a lot of 3rd party packages, such as getid3 from
> http://getid3.sourceforge.net/ and pear xml rpc  from
> http://pear.php.net/package/XML_RPC
> There appear to be plenty of these. Unfortunately the packaging guidelines
> don't permit including other software packages within a single package.
> Unfortunately this is a common problem with web applications since much of
> their target audience is shared hosting where the user doesn't have control
> over the host. If these already exist in fedora you can get either symlink or
> modify the source to look elsewhere. If they don't you'll need to get those
> packaged as well and symlink or modify source to point to them. 

I saw a similar issue with gallery2, which released a new version symlinked
to php-Smarty.

Well, I did not find getid3 in Fedora, and probably several of the others
are not also. But to pack and review all of them should take ages to complete
...

I am keeping ampache in ATrpms, and I have already incorporated almost all of
your suggestions in the current release (I will just move the server root to
/usr/share in the next release). Eventually, these applications will be packed
(I can do some of them), and we can return to this review in the future.

Thanks anyway.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.