[Bug 501130] Review Request: drbdlinks - A program for managing links into a DRBD shared partition

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501130





--- Comment #3 from Robert Scheck <redhat-bugzilla at linuxnetz.de>  2009-05-17 16:17:11 EDT ---
(In reply to comment #2)
> - Initscripts should be install on %{_initrddir}
>   (Unproper usage of rpm macros)

I want to package drbdlinks for all active branches and this is only possible
without macro usage currently, look for %{_initrddir} vs. %{_initdir} or so.

> - don't put a file on %{_localstatedir}/run. 
>   you should only create a directory on it

Upstream initscript doesn't do that as well. And drbdlinks isn't a daemon. It
also can be triggered by heartbeat. Thus /var/run doesn't make sense.

> - Who should owned %{_sysconfdir}/ha.d ?

Heartbeat owns that directory. But heartbeat is optional, drbdlinks can be
used with and without.

> drbdlinks.noarch: W: missing-lsb-keyword Default-Stop in
> /etc/rc.d/init.d/drbdlinksclean

If no Default-Start, no Default-Stop. The line has not to exist, if it is
not filled, IIRC.

> drbdlinks.noarch: E: subsys-not-used /etc/rc.d/init.d/drbdlinksclean
> drbdlinks.noarch: W: incoherent-init-script-name drbdlinksclean

As explained above.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.