[Bug 499959] Review Request: redmine - redmine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499959


Jan Klepek <jan.klepek at hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jan.klepek at hp.com
         AssignedTo|nobody at fedoraproject.org    |jan.klepek at hp.com
               Flag|                            |fedora-review?,
                   |                            |needinfo?(david.hannequin at g
                   |                            |mail.com)




--- Comment #5 from Jan Klepek <jan.klepek at hp.com>  2009-05-20 02:32:15 EDT ---
Hi David, 

I couldn't see you in packager cvs group, is this your first package for
fedora?

1] how do you get Source0,Source1,Source2? 
http://fedoraproject.org/wiki/Packaging/SourceURL

2] latest version is 0.8.4, wouldn't be better to have this version packaged?

3] use %{__cp} -p to preserver timestamps, better would be not to use %{__cp}
at all, you are doing a lot of chmods later, couldn't you use install? Most of
chmods are related to 5]

4] vendor/rails contains ruby library files: which have licensing: MIT for
actionmailer, actionpack, activerecord, activeresource, activesupport, GPLv2
for activemodel

5] this libraries are present as packages in fedora, so why do you need to
package it by yourself? put that into requirements. 
Except activemodel for which I couldn't see any package. So create package for
activemodel library ( use http://fedoraproject.org/wiki/Packaging/Ruby )

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.