[Bug 225794] Merge Review: ghostscript-fonts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225794





--- Comment #9 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-05-21 07:35:26 EDT ---
- This is a legacy font package, so Font guidelines are not valid here.

- Change
 Requires(post): /usr/bin/mkfontscale /usr/bin/mkfontdir
to
 Requires(post): xorg-x11-font-utils
as this is the package that provides those since Fedora Core 2 (2004).

- I'm not totally sure you need
 Requires(post): fontconfig
 Requires(postun): fontconfig
as you already have Requires: fontconfig. Besides, this is probably
automatically picked up by rpm. Doesn't hurt having them, though.

- Change references to /etc to %{_sysconfdir}

- Setting umask is probably not necessary as this is done by rpm.

- Replace `which mkfontdir` with plain mkfontdir.

- Drop
 %dir %{catalogue}
in %files section, as
 $ rpm -qf /etc/X11/fontpath.d/
 filesystem-2.4.19-1.fc10.i386
is already owned on every installation.

- I can't find a single mention of a license in the tarball!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.