[Bug 492224] Review Request: gnome-mud - MUD client for GNOME desktop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492224


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #6 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-05-22 04:29:06 EDT ---
Some notes:

* Spec file name
  - must be "gnome-mud.spec".

* License tag
  - The license tag "GPL" is invalid on Fedora:
    https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#GPL_and_LGPL
    For this package this should be "GPLv2+".

* BR (BuildRequires)
  - Please check if you really have to write explicit version
    dependency on BRs.
    Note that the least version currently supported by Fedora project is
    "Fedora 9". This means that if the package listed in your BR
    already has higher version on F-9 than is required in your spec file, 
    writing explicit version dependency is not likely to be needed.

  - Please remove redundant BuildRequires
    * This is GTK 2 package and "BR: gtk+-devel" is not needed
       ("gtk+-devel" is for GTK 1 package)

* description-line-too-long
  - Fedora requests that %description should not contain a line
    longer than 79 characters.

* Timestamps
  - Please consider to use
---------------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
---------------------------------------------------------------------
    to keep timestamps on installed files.
    This method usually works for Makefiles generated by recent
    autotools.

* Scriptlets
  - "desktop-file-validate" check must be at %install
    (i.e. after "make install" is done), not at %post
  - Please check GConf scriptlets
---------------------------------------------------------------------
%pre
....
 gconftool-2 --makefile-uninstall-rule \
 %{_sysconfdir}/gconf/schemas/%{name} .schemas >/dev/null || :
                                              ^^^^^^^
---------------------------------------------------------------------
      * There is a questionable space between "%name" and ".shemas"
  - You call scrollkeeper-update but no files are installed
    under %_datadir/omf/ (ref:
    https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Scrollkeeper
    )

* Directory ownership issue
  - The directory %{_datadir}/%{name} itself is not owned by any
    packages and this package must own this.
   
https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership
    https://fedoraproject.org/wiki/Packaging/UnownedDirectories

* Documents
  - Usually the file "INSTALL" is for people who want to build/install
    packages by themselves and not needed for people using rpm.

! By the way please make it sure that you change the release number
  of your spec file every time you modify your spec file
  and add some entry in %changelog (even during review request)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.