[Bug 226111] Merge Review: lvm2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226111





--- Comment #18 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-05-22 16:23:10 EDT ---
Okay.

Now:

- Time stamps aren't preserved in the install phase, adding INSTALL="install
-p" as argument to make install should fix that. Also, use the -p argument when
installing the scripts and config files to preserve the time stamp.

- Are you sure you want to use %define's instead of %global's?

- You can drop the license header on subpackages that have the same license as
the main package (cluster and device-mapper).

- You shouldn't need
 %attr(755,root,root) /%{_lib}/libdevmapper.so
a plain
 /%{_lib}/libdevmapper.so
should do. If not, it's better to change the permissions in the install phase.


rpmlint output:
device-mapper-devel.x86_64: W: no-documentation
device-mapper-libs.x86_64: W: obsolete-not-provided device-mapper
device-mapper-libs.x86_64: W: no-documentation
lvm2.src:31: W: unversioned-explicit-obsoletes lvm
lvm2.x86_64: W: obsolete-not-provided lvm
lvm2.x86_64: E: non-standard-executable-perm /sbin/lvm 0555
lvm2.x86_64: E: non-standard-dir-perm /var/lock/lvm 0700
lvm2.x86_64: E: non-standard-executable-perm /sbin/lvmdump 0555
lvm2.x86_64: E: non-standard-executable-perm /sbin/vgimportclone 0555
lvm2.x86_64: E: non-standard-executable-perm /sbin/fsadm 0555
lvm2.x86_64: E: non-standard-dir-perm /etc/lvm/backup 0700
lvm2.x86_64: W: hidden-file-or-dir /etc/lvm/cache/.cache
lvm2.x86_64: E: non-readable /etc/lvm/cache/.cache 0600
lvm2.x86_64: E: non-standard-dir-perm /etc/lvm/archive 0700
lvm2.x86_64: E: non-standard-dir-perm /etc/lvm/cache 0700
lvm2-cluster.x86_64: W: missing-lsb-keyword Required-Start in
/etc/rc.d/init.d/clvmd
lvm2-cluster.x86_64: W: missing-lsb-keyword Required-Stop in
/etc/rc.d/init.d/clvmd
lvm2-cluster.x86_64: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/clvmd
lvm2-cluster.x86_64: W: missing-lsb-keyword Short-Description in
/etc/rc.d/init.d/clvmd
lvm2-cluster.x86_64: W: no-reload-entry /etc/rc.d/init.d/clvmd
lvm2-cluster.x86_64: W: incoherent-init-script-name clvmd
7 packages and 0 specfiles checked; 9 errors, 12 warnings.

Out of these, I think you should fix:
- The permissions of the binaries in /sbin, they should probably be 755.
- The init file of clvmd must respect
 https://fedoraproject.org/wiki/Packaging/SysVInitScript

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.