[Bug 499483] Review Request: python-repoze-who-testutil - Test utilities for repoze.who-powered applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499483


Brennan Ashton <bashton at brennanashton.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |bashton at brennanashton.com
         AssignedTo|nobody at fedoraproject.org    |bashton at brennanashton.com
               Flag|                            |fedora-review+




--- Comment #1 from Brennan Ashton <bashton at brennanashton.com>  2009-05-23 22:45:33 EDT ---
[pass] source files match upstream:
62ff8edc30992cd2efc42fd973252c9deddfe29b2a53b7cf903743edcb356ab8 
repoze.who-testutil-1.0rc1.tar.gz

[pass] package meets naming and versioning guidelines.
[pass] specfile is properly named, is cleanly written and uses macros
consistently.
[pass] dist tag is present.
[pass] build root is correct.
 %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

[?] license field matches the actual license.
the license shown is BSD, but the actual license is a BSD like license is this
ok. http://www.repoze.org/LICENSE.txt
[?]license is open source-compatible.
see above
[?]license text not included upstream.
 setup.py in the source says that http://www.repoze.org/LICENSE.txt must be
distributed with it.

[pass] latest version is being packaged.
[pass] BuildRequires are proper.
[pass] compiler flags are appropriate.
[pass] %clean is present.
package builds in mock.
(cannot do this due to dep not yet in the repos) build fine outside of mock.
[pass] package installs properly.
[pass] rpmlint is silent.
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

[pass] final provides and requires are sane:
rpm -qp --requires
../RPMS/noarch/python-repoze-who-testutil-1.0-0.1.rc1.fc10.noarch.rpm 
python(abi) = 2.5
python-paste-deploy  
python-repoze-who  
python-zope-interface  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1

rpm -qp --provides
../RPMS/noarch/python-repoze-who-testutil-1.0-0.1.rc1.fc10.noarch.rpm 
python-repoze-who-testutil = 1.0-0.1.rc1.fc10


[broken] %check is present and all tests pass:
Has upstream been informed that they do not work so that they can be fixed in
future releases?

[pass] owns the directories it creates.
[pass] doesn't own any directories it shouldn't.
[pass] no duplicates in %files.
[pass] file permissions are appropriate.

[pass] code, not content.
[pass] documentation is small, so no -docs subpackage is necessary.
[pass] %docs are not necessary for the proper functioning of the package.
[pass not a GUI app] desktop files valid and installed properly.

Take a look at the license comments that I made. I think it is fine, and if it
looks right to use I APPROVE.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.