[Bug 502352] Review Request: php-markdown - Markdown implementation in PHP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502352





--- Comment #1 from Gianluca Sforna <giallu at gmail.com>  2009-05-24 11:06:49 EDT ---
Few items to check:

* rpmlint is not clean:

rpmlint
/var/lib/mock/fedora-10-x86_64/result/php-markdown-1.0.1m-1.fc10.src.rpm 
php-markdown.src:20: W: setup-not-quiet
php-markdown.src: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line
1)
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

add -q to the %setup line and file the tab/space issue


* php and unzip are not needed to build, php can stay as a Require: tough

* you may consider using the "install" command instead of mkdir+cp

the last one is not a "must".

Fix the first two items and I think I can approve the package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.