[Bug 484644] Review Request: screenlets - Fully themeable mini-apps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484644





--- Comment #20 from Sergio Pascual <sergio.pasra at gmail.com>  2009-05-27 07:57:59 EDT ---
A few quick comments:

* Please use command names consistently, you have both %{__python} and rm for
example. I recommend using python and rm (in the other hand, you can use
%{__python} and %{__rm}).

* "screenlets-manager > /dev/null" doesn't work. You don't have to redirect
stdout, it goes automatically to .xsession-errors on a graphic sessions. 
A simple

Exec=screenlets-manager 

in screenlets-manager.desktop does the job.

* You can join all the %{_bindir}/screenlets-whatever in %{_bindir}/*

* The directory %{_datadir}/icons/ for screenlets.svg seems wrong to me. In my
system is the only icon present there. I suggest
/usr/share/icons/hicolor/scalable/apps and add Requires: hicolor-icon-theme

* You must update the icon cache after installing screenlets.svg. See the
details here:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.