[Bug 473583] Review Request: wordnet - A lexical database for the english language

bugzilla at redhat.com bugzilla at redhat.com
Wed May 27 21:52:00 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473583





--- Comment #23 from steve <steve at lonetwin.net>  2009-05-27 17:51:59 EDT ---
(In reply to comment #22)
> Last thing, sorry for not noticing it earlier:

Thanks, you've been very patient. This is my first submission but still that
ought not to be an excuse for some of the basic things i've overlooked :).

Anyways, ...

> There are two problems here.
> 
> 1. You're not owning the %{_datadir}/%{name}-%{version}/ dir, just the
> directories beneath it.
> You can solve this problem by replacing the subdirs with wildcards with simply:
> %{_datadir}/%{name}-%{version}/
> 
> That translates into "own this directory and all files and directories
> underneath it".
Done.

> # Remove duplicate copies of docs installed by make install
> rm -rf $RPM_BUILD_ROOT%{_datadir}/%{name}-%{version}/doc 
Done.

> 
> Show me a new spec with both issues fixed and I'll finish this review off and
> sponsor you. :)  

Here goes:
http://www.lonetwin.net/wordnet.spec
http://lonetwin.net/wordnet-3.0-8.fc10.src.rpm


cheers,
- steve

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list