[Bug 502920] Review Request: polkit-gnome - PolicyKit integration for the GNOME desktop

bugzilla at redhat.com bugzilla at redhat.com
Thu May 28 20:08:36 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502920





--- Comment #4 from Matthias Clasen <mclasen at redhat.com>  2009-05-28 16:08:35 EDT ---
checklist

rpmlint: see above
package name: matches tarball name, ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: ok
license file: ok, but should probably updated to be straight LGPL, since the
daemon etc are gone

spec file language: ok
spec file legible: ok
upstream sources: missing
buildable: ok
excludearch: n/a
build deps: ok
locales: ok
shared libs: n/a
relocatable: n/a
directory ownership: ok
duplicate files: ok
permissions: ok
%clean: ok
macro use: ok
content: ok
large docs: n/a
%doc content: ok
header files: n/a
static libs: n/a
pc files: n/a
shared libs: n/a
devel deps: ok
gui apps: ok
file ownership: ok
%install: ok
utf8 filenames: ok


Should drop the --vendor gnome in the desktop-file-install call

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list