[Bug 492715] Review Request: KRadio4 - V4L/V4L2-Radio Application for KDE4

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492715





--- Comment #17 from Zarko (grof) <zarko.pintar at gmail.com>  2009-05-29 04:05:47 EDT ---
OK, I assigned this for review, but we have here some issues in spec file:

1. Please purify spec file. I mean that you drop your macro definitions for
snapshot and ffmpeg. ffmpeg must be droped out from spec file!

2. This version is snapshot. Can you expect  stable release soon?

3. I think that you do not need these BR-s:
   -chrpath (RPATHS resolved by %cmake_kde4 macro
   -gcc-c++
   -qt-devel
   Try to build without them

4. Please, try to use BuildRoot in form of this:
   BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
-n)

5. Please use kde4 macros for cmake, dirs, (I'll attach kdenlive.spec as
example)

6. .desktop file:
   Why you wrote .desktop file? Isn't a author's job?

7. Why you copy icons from /icons dir to /pixmaps?

8. %defattr must be %defattr(-,root,root,-)

9. {_datadir}/icons/hicolor/*/*/* you can write on this way:
   {_datadir}/icons/hicolor/*

10.Please, try to build this package with Koji (or local Mock) for F10 and F11
branches. It must be successfully!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.