[Bug 492221] Review Request: dssi-vst - DSSI plugin wrapper for VST plugins

bugzilla at redhat.com bugzilla at redhat.com
Fri May 29 12:25:13 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492221


Mattias Ellert <mattias.ellert at fysast.uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mattias.ellert at fysast.uu.se
               Flag|                            |fedora-review+




--- Comment #2 from Mattias Ellert <mattias.ellert at fysast.uu.se>  2009-05-29 08:25:10 EDT ---
Fedora review dssi-vst-0.8-2.fc10.src.rpm 2009-05-29

$ rpmlint *.rpm *.spec
dssi-vst-wine.i386: W: no-documentation
7 packages and 1 specfiles checked; 0 errors, 1 warnings.

* OK
? needs attention

* rpmlint is OK

* package is named according to guidelines

* specfile is named after the package

* package is licensed under a Fedora approved license (GPLv2)

* package license corresponds to the license of the package sources

* license file (COPYING) is included as %doc

* specfile is written in legible English

* sources matches upstream

$ md5sum dssi-vst-0.8.tar.gz SRPM/dssi-vst-0.8.tar.gz 
2d46474eaf84f0a2efc2389edaa18e3a  dssi-vst-0.8.tar.gz
2d46474eaf84f0a2efc2389edaa18e3a  SRPM/dssi-vst-0.8.tar.gz

* package builds in mock in ix86 and x86_64 (Fedora 10)

* package has exclusive arch for ix86 and x86_64 (requires wine)

* BuildRequires are sane

* package owns all directories it creates - both the main and wine
  subpackages own /usr/lib/dssi/dssi-vst, but that is necessary since
  the packages Require each other

* no duplicate files

* permissions are sane and %files has %defattr

* %clean clears buildroot

* specfile uses macros consistently

* package contains code

* subpackage interdepencies used fully qualified versions

? the wine subpackage owns /usr/lib/dssi which is also owned by the
  dssi package - should the wine subpackage require dssi instead?

* %install clears buildroot

* installed filenames are UTF8


The minor issue above you can fix post-review.


Package approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list