[Bug 503136] Review Request: csync - a file synchroniser utility
bugzilla at redhat.com
bugzilla at redhat.com
Fri May 29 20:12:54 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=503136
Jussi Lehtola <jussilehtola at fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |jussilehtola at fedoraproject.
| |org
AssignedTo|nobody at fedoraproject.org |jussilehtola at fedoraproject.
| |org
Flag| |fedora-review?
--- Comment #1 from Jussi Lehtola <jussilehtola at fedoraproject.org> 2009-05-29 16:12:53 EDT ---
- Don't use
%{summary}.
as description for the libs package. Use something along the lines of the
description of the devel package instead.
- Is the target platform stuff really necessary? Won't a simple
%{cmake_kde4}
make VERBOSE=1 %{?_smp_mflags}
do?
- Devel package should probably
Requires: %{name}-libs = %{version}-%{release}
instead of
Requires: %{name} = %{version}-%{release}
- Libs should not
Requires: %{name} = %{version}-%{release}
Is there even a need to have a separate package for the library? I'd put them
in the main package.
- Devel package must own
%{_includedir}/csync/
instead of
%{_includedir}/csync/*
otherwise it will not own the directory.
- Main package must own
%dir %{_sysconfdir}/csync/
as it places files in that directory
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list