[Bug 516532] Review Request: globus-scheduler-event-generator - Globus Toolkit - Scheduler Event Generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516532


Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Steve Traylen <steve.traylen at cern.ch>  2009-11-01 13:39:20 EDT ---
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1781516

Review of globus-scheduler-event-generator:

yes: rpmlint

$ rpmlint SRPMS/globus-scheduler-event-generator-2.1-1.fc12.src.rpm \ 
         
RPMS/noarch/globus-scheduler-event-generator-doc-2.1-1.fc12.noarch.rpm \
          RPMS/x86_64/globus-scheduler-event-generator-* \
          SRPMS/globus-scheduler-event-generator-2.1-1.fc12.src.rpm 
globus-scheduler-event-generator-debuginfo.x86_64: E: description-line-too-long
This package provides debug information for package
globus-scheduler-event-generator.
globus-scheduler-event-generator-devel.x86_64: W: no-documentation
globus-scheduler-event-generator-progs.x86_64: W: no-documentation
7 packages and 0 specfiles checked; 1 errors, 2 warnings.

which is all fine.

yes: Package name
yes: spec file name
yes: general and globus guidelines.
yes: license in spec
yes: matches actual license.
yes: GLOUBUS_LICESNSE file included.
yes: English spec file
yes: legible spec file.
yes: source matches.
yes: comnpiles, see koji above.
yes: compiles on all arches anyway.
yes: build requires good.
yes: no locales anyway.
yes: calls ldconfig suitably.
yes: no system libs.
yes: not relocatable.
yes: owns all files and dirs.
yes: no duplicate files.
yes: all default perms.
yes: %clean has a rm -rf 
yes: consistant macros
yes: code is present.
yes: docs are in a docs package.
yes: docs not needed runtime.
yes: header files in -devel package.
yes: no static files anyway.
yes: no .la files.
yes: no gui part anyway.
yes: does not own files from other packages.
yes. %install is cleared first.
yes: utf8 filenames.

an easy approve:

APPROVED:

Steve

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.