[Bug 523343] Review Request: zikula-module-EZComments - Simple Zikula module that provides comment functions to other modules

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523343





--- Comment #11 from Jon Stanley <jonstanley at gmail.com>  2009-11-02 21:51:21 EDT ---
OK, this is quite interesting.  This package technically looks fine to me, but
in doing a formal review I ran into a little glitch.

First, the upstream URL (that's listed as a direct link on the download page)
gives me a 403 when I try to get it with wget. That's excusable, somewhat.
What's not is that when I went to the upstream webpage and downloaded the
source, the md5sum didn't match:

ef71cfcec8a3cc4dcde845dc0ca47240  module_EZComments_1-61.zip
c8ed22422179645bd244f768ec513ad7 
../rpmbuild/SOURCES/module_EZComments_1-61.zip

Upon further investigation into this discrepancy, I found that apparently some
translations were included in the version that I had downloaded that were not
in the (ostensibly same) version in the SRPM:

[jstanley at rugrat ~]$ diff zik-dl.find zikula-tmp/zik-pk.find 
27d26
< ./modules/EZComments/pnlang/spa/common.php
29,30d27
< ./modules/EZComments/pnlang/fra/template_Standard.php
< ./modules/EZComments/pnlang/fra/common.php
33d29
< ./modules/EZComments/pnlang/ces/common.php
35d30
< ./modules/EZComments/pnlang/nor/common.php
37d31
< ./modules/EZComments/pnlang/ita/common.php
39,40d32
< ./modules/EZComments/pnlang/nld/template_Standard.php
< ./modules/EZComments/pnlang/nld/common.php
45,46d36
< ./modules/EZComments/pnlang/deu/template_Standard.php
< ./modules/EZComments/pnlang/deu/common.php
[jstanley at rugrat ~]$ cd zikula-tmp/
[jstanley at rugrat zikula-tmp]$ ls -l ./modules/EZComments/pnlang/deu/common.php
ls: cannot access ./modules/EZComments/pnlang/deu/common.php: No such file or
directory

I'm not exactly sure what to do about this - this is poor upstream release
practices, but failing the most basic check in the package review process sort
of blocks it from Fedora, but it also doesn't seem right to block a package
simply because upstream doesn't have their act together.

Upstream should: 

1) Provide a static URL that will forever lead to the *same* version of a
package - no additional translations, no additional code, etc - the
md5sum/sha1sum should be identical.
2) Refrain from releasing a new version with simply more translated strings
without bumping the version (sorta a natural consequence of item 1).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.