[Bug 507083] Review Request: poco - C++ class libraries for network-centric applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507083





--- Comment #11 from Michal Schmidt <mschmidt at redhat.com>  2009-11-03 13:44:24 EDT ---
Maxim,

For now I have just a couple of suggestions:
- Please do not use the "-s" option for make. Full logs from the compilation
should always be present in Koji builds.

- You don't have to use perl to do simple substitutions. sed is capable enough
and it's always present in the buildroots. For example:
sed -i.orig -e 's|$(INSTALLDIR)/lib\b|$(INSTALLDIR)/%{_lib}|g' Makefile
The other two substitutions use the same script, so they can even be merged
into a single sed invocation.
Oh, and %{_libdir} is nicer than /usr/%{_lib}.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.