[Bug 531912] Review Request: perl-Net-ARP - Create and Send ARP Packets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531912





--- Comment #3 from Ruben Kerkhof <ruben at rubenkerkhof.com>  2009-11-03 16:53:53 EDT ---
Ah, thanks!

The normal procedure is for you to update the release field in the spec file,
and post a link to the updated spec and srpm here.

You haven't addressed the first issue yet (rm -rf %{buildroot})

Just a few more comments:
-
/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Net/ARP/ARP.bs
is an empty file and I don't think it's needed.

- Rename the .spec to perl-Net-ARP.spec (with capitals R and P). The spec has
to have the same name as the package. (rpmlint also complains about this when
you run it on the src.rpm).

- Why not make pure_install?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.