[Bug 516522] Review Request: globus-nexus - Globus Toolkit - Nexus Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516522


Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |steve.traylen at cern.ch
               Flag|                            |fedora-review+




--- Comment #1 from Steve Traylen <steve.traylen at cern.ch>  2009-11-03 17:48:43 EDT ---
Review of globus-nexus:

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1786846

yes: rpmlint
$ rpmlint SPECS/globus-nexus.spec RPMS/x86_64/globus-nexus-* 
   SRPMS/globus-nexus-6.7-1.fc12.src.rpm 
globus-nexus-devel.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 0 errors, 1 warnings.

yes: package named as per-globus.
yes: spec file correct.
yes: globus guidelines good.
yes: ASL 2.0 in .spec
yes: contents is also ASL 2.0
yes: GLOBUS_LICEENSE include.
yes: english .spec
yes: legible spec.
yes: upstream matches.
$ diff --brief --recursive
gt4.2.1-all-source-installer/source-trees/nexus/source
~/rpmbuild/SOURCES/globus_nexus-6.7
Only in /home/steve/rpmbuild/SOURCES/globus_nexus-6.7: GLOBUS_LICENSE
which is expected.
yes: compiles , see koji above.
yes: builds on all archs.
yes: builds on all archs.
yes: build dependencies sane.
yes: no locales anyway.
yes: ldoconfig called correctly.
yes: no statics.
yes: owns all directories.
yes: no duplicate files.
yes: all %defattr.
yes: %clean is cleaned.
yes: contains code.
yes: no large docs anyway.
yes: doc not needed.
yes: headers are in devel.
yes: pkgconfig required.
yes: devel does require base explicitly.
yes: no gui.
yes: owns all files or directories or pulls them in.
yes: %install is cleaned.
yes: utf8.

just libs all easy.

APPROVED.

Steve

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.