[Bug 531987] Review Request: wtop - top for webserver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531987





--- Comment #4 from Parag AN(पराग) <panemade at gmail.com>  2009-11-05 01:18:58 EDT ---


Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1781942
+ rpmlint output for SRPM and for RPM.
wtop.src: W: no-buildroot-tag
==> Ok to ignore
+ source files match upstream url(sha1sum)
9f715744779b997935840a2cf97211533a446aca  wtop-0.6.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

Suggestions
you can change that path in spec in %prep as
sed -i -e "s|/var/log/apache2/|/var/log/httpd/|" wtop.cfg
APPROVED.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.