[Bug 532779] Review Request: gtraffic - Simple traffic usage counter for mobile broadband connections

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532779


Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Christoph Wickert <cwickert at fedoraproject.org>  2009-11-05 07:16:54 EDT ---
Hmm, I don't like the way you rename trafficd. Why cp and rm, why not simply
mv? I don't even like touching things in %{buildroot} after install, IMO this
should be patched in the Makefile/in setup.py. After all, it's us decision if
you want to rename the program, I wouldn't call it a blocker. ATM there are no
collisions with trafficd, but in long term at least theoretically there could
be some.

I suggest to leave it trafficd for now and ask upstream if renaming is ok for
him. If you need something to support your point of view, tell him about
https://fedoraproject.org/wiki/Packaging_tricks#Use_of_common_namespace

Items to check:
Ok - Requires: are correct now
OK - Spelling of NetworkManager is correct

One last thing: Changelog is wrong: gnome-python2-gconf is R instead of BR. I
suggest you change that line to "Require NetworkManager and
gnome-python2-gconf", this is what everybody will understand.

Anyway, the package is APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.