[Bug 531051] Review Request: glite-security-util-java - Java Utilities for GSI Credentials

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531051


Mattias Ellert <mattias.ellert at fysast.uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




--- Comment #1 from Mattias Ellert <mattias.ellert at fysast.uu.se>  2009-11-07 11:10:50 EDT ---
Fedora review glite-security-util-java 2009-11-07

+ OK
- Needs work
? Needs explanation

$ rpmlint glite-security-util-java-*
glite-security-util-java.src:123: W: libdir-macro-in-noarch-package (main
package) %attr(-,root,root) %{_libdir}/gcj/%{name}/%{name}-%{version}.jar.*
4 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ rpmlint OK

+ Package named according to Java guidelines (name same as jarfile)

+ Specfile named after package

+ License tag "ASL 2.0 and EU Datagrid" is a Fedora apporved license

+ The tag corresponds to the license in the sources (most is ASL 2.0, but
  the code in src/org/glite/security/voms/ac is EU Datagrid

+ LICENSE file is listed as %doc

+ Specfile is written in legible English

+ Sources corresponds to upstream (following the description in the specfile)

+ Package compiles as a mock build

+ Build requirements are sane

- The source tree contains an embedded copy of the source for the
  vomsjapi library in src/org/glite/security/voms, bundling copies of
  system libraries is not allowed - use the system version instead

This can be achieved by adding the following lines to the %prep section ...

rm -rf src/org/glite/security/voms
sed s/org.glite.security.voms.VOMSValidator/org.glite.voms.VOMSValidator/ \
    -i src/org/glite/security/SecurityContext.java

... and adding vomsjapi to BuildRequires, Requires and build-classpath

It might then also be possible to change the License tag to only "ASL 2.0"
since the code under the other license is then not used.


- Package does not own /usr/lib64/gcj/glite-security-util-java

+ No duplicate files

+ Permissions are sane and %files has %defattr.

Though the %attr(-,root,root) tag for the gcj AOT files is redundant -
covered by the default.


+ %clean clears buildroot

+ Specfile uses macros consistently

+ Package contains code

- The javadoc package does not have a versioned directory and a symlink

+ Package does not own others' directories

+ %install clears buildroot

+ Filenames are UTF8

? axis and servlet are listed as BuildRequires but not as Requires - why?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.