[Bug 469931] Review Request: ipmiutil - IPMI Management Utilities

bugzilla at redhat.com bugzilla at redhat.com
Sun Nov 8 02:57:52 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469931


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |BuildFails




--- Comment #15 from Jason Tibbitts <tibbs at math.uh.edu>  2009-11-07 21:57:49 EDT ---
The package in comment 14 fails to build for me:

+ cd /builddir/build/BUILDROOT/ipmiutil-2.4.3-1.x86_64/usr/share/man/man8
+ gzip -f '*.8'
gzip: *.8: No such file or directory

I'm not sure what's gone wrong, but do note that you shouldn't try to compress
the manpages yourself; rpmbuild will do it automatically.

The %ifarch doesn't seem at all relevant to Fedora, and I have to admit that I
can't understand why you would define all of those macros that are pretty much
the same as existing macros or are longer than the strings they replace.

I don't understand the purpose of %pre; packages cannot produce output in
scriptlets, so the whole thing seems to be pointless.  And the checks for SuSE
and Montavista in %post have no place in Fedora.  Many other portions of the
scriptlets don't seem relevant to Fedora.

Please clear the whiteboard when you have a package which builds.

I checked the account system and it looks like you are not in the packager
group, so I've indicated that you need a sponsor.  Please read through
http://fedoraproject.org/wiki/Join_the_package_collection_maintainers for more
information on becoming a Fedora packager.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list