[Bug 532402] Review Request: APF - Advanced Policy Firewall

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532402


Scott Collier <boodle11 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |boodle11 at gmail.com




--- Comment #1 from Scott Collier <boodle11 at gmail.com>  2009-11-08 13:02:54 EDT ---
Hi Mark,

I'm not a sponsor, I just have some general recommendations about your package.
 This is my first review, so please let me know if there are any questions.

1. The package didn't build on my system due to permissions on directories on
/etc/apf

http://boodle.fedorapeople.org/RPMS/error.out

2. rpmlint has a few messages:
$ rpmlint apf.spec
apf.spec: W: no-cleaning-of-buildroot %install
apf.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 1)

$ rpmlint ../SRPMS/apf-9.7-1.src.rpm
apf.src: W: no-version-in-last-changelog
apf.src: W: no-cleaning-of-buildroot %install
apf.src: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 1)
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Please correct these.

3. Your buildroot is probably fine, but Fedora does have preferences, please
use a buildroot from:
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag


4. source0 should be URL to source file, please see:
https://fedoraproject.org/wiki/Packaging:SourceURL

5. Add a version to the last changelog entry

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.