[Bug 532203] Review Request: jgraph - Java-based Diagram Component and Editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532203





--- Comment #11 from Lubomir Rintel <lkundrak at v3.sk>  2009-11-10 09:46:34 EDT ---
Thanks for your time and review.

(In reply to comment #9)
> [!] MUST: All build dependencies must be listed in BuildRequires, except for
> any that are listed in the exceptions section of the Packaging Guidelines ;
> inclusion of those as BuildRequires is optional. Apply common sense.
> Am I being a bit dense, or is there a "Requires: java" missing?

You're right. In fact, I the package should depend on jpackage-utils since it
owns /usr/share/java this package used. Added a dependency on jpackage-utils,
it also depends on java so it's not necessary to list it twice.

> [!] SHOULD: The reviewer should test that the package functions as described. A
> package should not segfault instead of running, for example.
>  The examples do not compile. This requires the "l2fprod-common" jar. This is
> in the repos, so please create a README.fedora describing how to install deps
> for and run the examples. You may wish to compile the examples directory with
> ant compile-examples during build time -- obviously you need to then add
> BuildRequires: l2fprod-common.

I'm quite reluctant to do this since it's extra work for virtually no benefit
(and just a SHOULD, not MUST). It's not a common practice either. If you insist
on verifying functionality you insist on doing so I suggest you try to build
something that depends on it (say, microba, see bug #532205). It would be
rather uncommon for a Java library not to function once it compiles though.

(In reply to comment #10)
> >If you fix these issues, then I will approve the package.  
> Just to clarify, I am not a sponsor. I will be happy with the review, however.  

I am already sponsored (in fact, I'm a sponsor), so I don't need a sponsor to
review packages. Anyone who's in the packager group (e.g. you) can review my
packages (this ticket would block FE_NEEDSPONSOR if I needed a sponsor).

New package:

SPEC: http://v3.sk/~lkundrak/SPECS/jgraph.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/jgraph-5.13.0.0-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.