[Bug 536694] Review Request: clamtk - GUI frontend for ClamAV

bugzilla at redhat.com bugzilla at redhat.com
Wed Nov 11 14:03:52 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=536694





--- Comment #6 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-11-11 09:03:51 EDT ---
Oh OK, sorry. Some notes:

- Source needs to honor Source URL guideline
http://fedoraproject.org/wiki/Packaging/SourceURL

- Missing Requires: desktop-file-utils due to usage of update-desktop-database.

- Mixing of "clamtk" and "%{name}" in %files is IMHO bad style. Change
 %{_datadir}/pixmaps/clamtk.png
to
 %{_datadir}/pixmaps/%{name}.png
or replace occurrences of "%{name}" with "clamtk".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list