[Bug 537631] Review Request: moblin-panel-web - Moblin Panel for Web Browsing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537631





--- Comment #1 from Christian Krause <chkr at plauener.de>  2009-11-16 18:11:02 EDT ---
Before I do the full review here are some issues I've seen so far:

1. the Source0 URL seems to be not working, the server returns "404 Not found"
(probably we should ask upstream to tag the releases in git ;-) )

IMHO it would be better to use only the file name as Source0 (the complete URL
could be kept in a comment for later when upstream has tagged the releases) -
otherwise it is misleading...

2. it looks like that the BR xulrunner-devel is not needed

3. are you planning to package the moblin web browser as well? In this case I
would recommend that moblin-panel-web requires the moblin-web-browser
(otherwise it just won't do anything... ;-) )

4. regarding the License I'm not sure: the sources in common/ are LGPLv2.1 but
the main application seems to be GPLv2+ - I've asked on the fedora-legal
mailing list for clarification...

I'm really looking forward to get a full moblin UI for Fedora! ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.