[Bug 538327] Review Request: otpd - One Time Password daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538327


Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org




--- Comment #2 from Thomas Spura <tomspur at fedoraproject.org>  2009-11-18 17:21:52 EDT ---
Just a few comments for now:

- License GPL is wrong: GPLv2+ is the right one
- The builds fails:
gcc  -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -D_REENTRANT -DUSE_SOCKET
-DHAVE_CLOCK_GETTIME -DVERSION=\"3.2.0\" -Wp,-U_FORTIFY_SOURCE
-U_FORTIFY_SOURCE -Wshadow -Wsign-compare -Werror -c -o failover_thread.o
failover_thread.c
cc1: warnings being treated as errors
failover_thread.c: In function 'failover_thread':
failover_thread.c:109: error: dereferencing pointer 'uicp' does break
strict-aliasing rules
failover_thread.c:109: note: initialized from here
failover_thread.c:110: error: dereferencing pointer 'uicp' does break
strict-aliasing rules
failover_thread.c:110: note: initialized from here
failover_thread.c:162: error: dereferencing pointer 'uicp' does break
strict-aliasing rules
failover_thread.c:162: note: initialized from here
failover_thread.c:267: error: dereferencing pointer '({anonymous})' does break
strict-aliasing rules
failover_thread.c:267: note: initialized from here
make: *** [failover_thread.o] Error 1

- run make %{?_smp_mflags} and not just make, see
https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make

- use make install DESTDIR=$RPM_BUILD_ROOT and not %makeinstall, see
https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

- in %clean, please just run rm -rf $RPM_BUILD_ROOT

- Source needs to contains a url, where you downloaded it, e.g.
  http://otpd.googlecode.com/files/%{name}-%{version}.tar.gz

- I'm unsure, if the Packager and Vendor tag is in fedora only not used or not
allowed. From
https://fedoraproject.org/wiki/Packaging/Guidelines#Rpmlint_Errors it's just
not used...


- The description is misleading (at least for me):
  "otpd is part of a suite of software"... Which suite?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.