[Bug 539231] Review Request: perl-CGI-Application-Plugin-SuperForm - Create sticky forms with HTML::SuperForm
bugzilla at redhat.com
bugzilla at redhat.com
Fri Nov 20 09:18:31 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=539231
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> 2009-11-20 04:18:29 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1819061
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
99376e7e79b527738cc4b9fd48cb1556ea05ed50
CGI-Application-Plugin-SuperForm-0.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=9, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.12 cusr 0.03
csys = 0.17 CPU)
+ Package perl-CGI-Application-Plugin-SuperForm-0.4-2.fc13.noarch =>
Provides: perl(CGI::Application::Plugin::SuperForm) = 0.4
Requires: perl(Exporter) perl(HTML::SuperForm) perl(strict) perl(vars)
perl(warnings)
+ Not a GUI application
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list