[Bug 508351] Review Request: josm - java openstreetmap editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508351





--- Comment #19 from Guido Grazioli <guido.grazioli at gmail.com>  2009-11-21 09:33:22 EDT ---
Some notes:

- man page should not be in %doc, and better glob extension as well

- you need to update icon cache because you install a new icon:
# ScriptletSnippet from Fedora Packaging on Icon Cache
%post
touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :

%postun
if [ $1 -eq 0 ] ; then
    touch --no-create %{_datadir}/icons/hicolor &>/dev/null
    gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
fi

%posttrans
gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :

- why aren't you keeping change history in %changelog? 

- you could set file permissions within install command instead of running
chmod after it

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.