[Bug 537451] Review Request: eclipse-emf-query - Specify and execute queries against EMF models

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537451


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |lkundrak at v3.sk
         AssignedTo|nobody at fedoraproject.org    |lkundrak at v3.sk
               Flag|                            |fedora-review?




--- Comment #1 from Lubomir Rintel <lkundrak at v3.sk>  2009-11-21 14:27:46 EDT ---
* Package name and version are in accordance with packaging guidelines
* SPEC file clean, legible and well-commented
* License tag correct, license packaged as %doc
* Filelist okay, for directories it uses and does now it depends on packages
that provide them
* Provides/Require list ok
(mock build did not finish yet)

Objections:

1.) Why do you check stuff out from CVS?

2.) Please don't pretty-format the Description, please use complete sentences.
It does not always look well in package management front-ends.

3.) RPMLint:

eclipse-emf-query.noarch: W: spurious-executable-perm
/usr/share/doc/eclipse-emf-query-1.3.0/epl-v10.html
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

eclipse-emf-query.noarch: W: spurious-executable-perm
/usr/share/doc/eclipse-emf-query-1.3.0/notice.html
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.