[Bug 539268] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rail

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=539268


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-11-21 15:03:27 EDT ---
Some quick notes:

* %define -> %global
  - Now Fedora prefers to use %global than %define:
   
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

* License
  - is MIT

* Source
  - Please use http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem

* Requires/BuildRequires
  - "Requires: ruby(abi) = 1.8" is a must:
    https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines
    Also I usually suggest to add "BuildRequires: ruby(abi) = 1.8"
    for consistency.

  - Please check the needed Requires manually.
    For example (only an example), lib/will_paginate.rb contains:
-------------------------------------------------------------
     1  require 'active_support'
-------------------------------------------------------------
    This means this binary rpm should have at least
    "Requires: rubygem(activesupport)".
    ! Note: use "rubygem(activesupport)" virtual Provides style for
      Requires instead of using rpm names directly, ref:
      https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides

* Using macros
  - As %geminstdir is defined, please replace
%{gemdir}/gems/%{gemname}-%{version}/
    (in %files) with this.
  - %ruby_sitelib seems to be used nowhere (in this spec file).

* Duplicate files
  - Please fix below:
-------------------------------------------------------------
    57  warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/will_paginate-2.3.11/CHANGELOG.rdoc
    58  warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/will_paginate-2.3.11/LICENSE
    59  warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/will_paginate-2.3.11/README.rdoc
-------------------------------------------------------------
    https://fedoraproject.org/wiki/Packaging/Guidelines#Duplicate_Files
    - Note: please keep these files marked as %doc.

* Test program
  - As this rpm contains %geminstdir/test/ please add %check section and
    execute some test program (some extra BuildRequires are also needed).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.