[Bug 529374] Review Request: ethos - Plugin framework for GLib

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529374





--- Comment #1 from Josephine Tannhäuser <josephine.tannhauser at googlemail.com>  2009-11-22 04:46:04 EDT ---
Just an informal review

OK - MUST: $ rpmlint 
ethos.i686: W: devel-file-in-non-devel-package
/usr/lib/ethos/plugin-loaders/libcloader.so
ethos.i686: W: devel-file-in-non-devel-package
/usr/lib/ethos/plugin-loaders/libpythonloader.so
ethos.i686: W: devel-file-in-non-devel-package
/usr/lib/ethos/plugin-loaders/libjsloader.so
these libfiles are needed, so it doesn't make sense to move them to -devel. if
so, the basepkg will require the develpkg by default. this would be senseless
ethos-devel.i686: W: no-documentation
ethos-python.i686: W: no-documentation
ethos-vala.i686: W: no-documentation
you have a doc package, so this should be okay
NOT OKAY - MUST: Named according to the Package Naming Guidelines
the name of the package should be libethos, because it is a lib
Group:          System Environment/Libraries
NOT OKAY - MUST: Spec file name matches the base package %{name} 
should be libethos
OK - MUST: Package meets the Packaging Guidelines
NOT OKAY - MUST: Fedora approved license and meets the Licensing Guidelines
License is LGPLv2+, and this is a good license
NOT OKAY - MUST: License field in spec file matches the actual license
License:        LGPLv2+
OK - MUST: License files included in %doc
OK - MUST: Spec is in American English
OK - MUST: Spec is legible
NOT OKAY - MUST: Sources match the upstream source by MD5
your command "git clone git://git.dronelabs.com/ethos" give me a newer
revision, you should add the command to co this version. then the md5sum od DL
and pacakge should match.
OK - MUST: Successfully compiles and builds into binary rpms on i686
CAN'T TEST IT, I HAVEN'T A KOJI-ACCESS - MUST: If the package does not
successfully compile, build or work on an architecture, then those
architectures should be listed in the spec in ExcludeArch.
If you want to import this to f12, too, you should do a kojibuild for f12 to
see if this will be build on all f12 supported architectures.
OK - MUST: All build dependencies are listed in BuildRequires.
N/A - MUST: Handles locales properly with %find_lang
OK - MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
N/A - MUST: If the package is designed to be relocatable, the packager
muststate this fact in the request for review.
OK - MUST: Owns all directories that it creates
OK - MUST: No duplicate files in the %files listing
OK - MUST: Permissions on files are set properly, includes %defattr(...)
OK - MUST: Package has a %clean section, which contains rm -rf %{buildroot}.
OK - MUST: Consistently uses macros
OK - MUST: Package contains code, or permissable content
OK - MUST: Large documentation files should go in a -doc subpackage
OK - MUST: Files included as %doc do not affect the runtime of the application
N/A - MUST: Header files must be in a -devel package
N/A - MUST: Static libraries must be in a -static package
OK - MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'.
N/A - MUST: If a package contains library files with a suffix, then library
files that end in .so must go in a -devel package.
N/A - MUST: devel packages must require the base package using a fully
versioned dependency
OK - MUST: The package does not contain any .la libtool archives.
N/A - MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
OK - MUST: Package does not own files or directories already owned by other
packages.
OK - MUST: At the beginning of %install, the package runs rm -rf %{buildroot}.
OK - MUST: All filenames valid UTF-8


SHOULD Items:
OK - SHOULD: Source package includes license text(s) as a separate file.
N/A - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
OK - SHOULD: Builds in mock.
CAN'T TEST, BECAUSE I HAVEN'T AN ACCESS TO KOJI - SHOULD: Compiles and builds
into binary rpms on all supported architectures.
OK - SHOULD: Functions as described.
Is required for emerillon. and emerillon works for me, so this should working,
too....
OK - SHOULD: Scriptlets are used, those scriptlets must be sane.
OK - SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
OK - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg
N/A - SHOULD: If the package has file dependencies outside of /etc, /bin,
/sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the
file instead of the file itself.


Other items:
N/A - latest stable version
git snapshot 
NOT OKAY - SourceURL valid
# git clone git://git.dronelabs.com/ethos
you have girrevision: 9d3aae9 as source0 you should add the command how to co
(explicit) this version and not the newest one.
If i tried this I would get a newer one co
OK - Compiler flags ok
OK - Debuginfo complete

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.