[Bug 532523] Review request: jarjar - Jar Jar Links

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532523


Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?




--- Comment #7 from Steve Traylen <steve.traylen at cern.ch>  2009-11-23 14:13:03 EDT ---
Hi Mary,
The review looks good, just change the docs to noarch and I'll approve.

Steve


http://koji.fedoraproject.org/koji/taskinfo?taskID=1825761

yes: rpmlint above.
yes: package name.
yes: spec file name
yes: package guidelines.
yes: GPLv2+ in .SPEC
yes: GPLv2+ in reality. 
yes: COPYING file included.
yes: english spec.
yes: legible spec.
yes: source matches upstream.
$ md5sum jarjar-src-0.9.zip ~/rpmbuild/SOURCES/jarjar-src-0.9.zip 
61825e60d0466e328c7d24a6cef2c643  jarjar-src-0.9.zip
61825e60d0466e328c7d24a6cef2c643 
/home/steve/rpmbuild/SOURCES/jarjar-src-0.9.zip

yes: builds (fc13)
yes: build requires sane.
yes: buils on archs - see koji
yes: no locaes.
yes: no ldconfig needed.
yes: no system libs.
yes: not reloc'
yes: no duplicates.
yes: pulls in jpackage-utils to own directories
yes: everything %defatt
yes: cleans everything.
yes: macro use good.
yes: contains code.
yes: java doc in seperate package.
yes: %doc not needed runtime.
yes: no devel package.
yes: no static libs.
yes: no pkgconfig files.
yes: no devel packages.
yes: no .la files.
yes: no gui.
yes: %install cleans itself.
yes: utf8.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.