[Bug 541533] Review Request: hunspell-si - Sinhala hunspell dictionaries

bugzilla at redhat.com bugzilla at redhat.com
Thu Nov 26 09:08:35 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541533


Caolan McNamara <caolanm at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




--- Comment #1 from Caolan McNamara <caolanm at redhat.com>  2009-11-26 04:08:33 EDT ---
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1831772
+ rpmlint is silent for SRPM and for RPM except for "Sinhala" not being in the
US English dictionary
+ source files match upstream.
2bca6e63410493f9c70c1b594c55c661 sinhala_spellchecker-0.2-fx.xpi
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English except for "Sinhala" not being in
the US English dictionary
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
- License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list