[Bug 225719] Merge Review: efax

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225719


Jaroslav Reznik <jreznik at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #1 from Jaroslav Reznik <jreznik at redhat.com>  2009-11-27 08:35:39 EDT ---
- rpmlint: NOT OK!!!
efax.src: W: summary-ended-with-dot A program for faxing using a Class 1, 2 or
2.0 fax modem.
efax.x86_64: W: log-files-without-logrotate /var/log/fax

- spec file name: OK
- package name: OK
- package version: release should start with 0., alpha tag should go to release
instead version
according to Package Guidelines but as this package can be considered as
successor to 0.9 (not
pre 0.9) this is OK
- license: OK
- group: OK
- url: OK
- sources URL: FAILED to download tarball
    * correct URL http://www.cce.com/efax/download/efax-0.9a-001114.tar.gz
- md5sum: OK (compared to upstream tarball above)
- exclude arch: no rules for s390, OK
- buildroot: OK
- requires: make and probably netpbm-progs (?) should be BuildRequires, not
Requires, NOT OK!!!
- description: OK
- build flags: missing smp_mflags, custom build flags?, NOT OK!!!
- macros used consistently: OK
- clean section: OK
- file attributes: OK
- docs: OK
- package owns directories: OK
- no duplicate files: OK

- package builds on: F-12/x86_64 OK

Than, please fix/comment issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.