[Bug 541694] Review Request: php-phpunit-File-Iterator - FilterIterator implementation that filters files based on a list of suffixes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541694





--- Comment #6 from Remi Collet <fedora at famillecollet.com>  2009-11-28 09:03:19 EDT ---
REVIEW:

+ rpmlint is ok
php-phpunit-File-Iterator.src: I: checking
php-phpunit-File-Iterator.noarch: I: checking
php-phpunit-File-Iterator.noarch: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
+ package name ok
+ spec file name ok
+ package meet the PHP Guidelines 
+ License ok : BSD
+ License is upstream 
+ spec in english and legible
+ no license file in sources
+ sources match the upstream sources
8bd52abf03f3c8f86d296b4ee5d3d39d  File_Iterator-1.1.0.tgz
+ Source URL ok
+ build  on F12.x86_64
+ BuildRequires (php-pear >= 1:1.7.2, php-channel(pear.phpunit.de)) ok
+ no locale
+ no .so
- DONT own all directories that it creates
+ no duplicate file
+ %defattr ok
+ %clean section
+ use macros consistently
+ contain code
+ no documentation
+ no devel
+ no pkgconfig
+ no sub-package
+ no GUI
+ don't own files or directories already owned by other packages
+ %install start with rm -rf 
+ valid UTF-8
+ build in koji (dist-f13)
http://koji.fedoraproject.org/koji/taskinfo?taskID=1835237
+ no test suite
+ scriptlets ok
+ Final Requires ok
/usr/bin/pear  
php-channel(pear.phpunit.de)  
php-common >= 5.2.0
+ Final Provides ok
php-pear(pear.phpunit.de/File_Iterator) = 1.1.0
php-phpunit-File-Iterator = 1.1.0-3.fc8


Changing minimal dependency for PEAR seems acceptable as it's only for
"installer"


MUST fix:
- own /usr/share/pear/File

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.