[Bug 541491] Review Request: rubygem-ruby_parser - A ruby parser written in pure ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541491


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-11-28 10:58:51 EDT ---
Some notes:

* Explicit version dependency
  - ">= 3.0" on Requires: rubygem(sexp_processor) is redundant
    because all rubygem-sexp_processor shipped on Fedora satisfies
    this version dependency:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

* %check
----------------------------------------------------------------
    16  # These test cases are carried in the ParseTree gem in test/. Carry
them here
    17  # rather than attempting to install ParseTree-doc in check and
introducing a circular
    18  # dependency
    19  Source1: pt_testcase.rb
    79  %check
    80  pushd .%{geminstdir}
    81  cp %{SOURCE1} test/
    82  rake test
----------------------------------------------------------------
  - IMO if this script is really needed for "rake test" (and actually
    it seems so), this script should also be included in the rebuilt
    binary rpm (i.e. better to move the lines 80-81 to %build).

? Dependency loop
  - lib/gauntlet_rubyparser.rb contains:
----------------------------------------------------------------
     8  require 'rubygems'
     9  require 'ruby2ruby'
    10  require 'ruby_parser'
    11  
    12  require 'gauntlet'
----------------------------------------------------------------
    i.e. this script needs two other gems: "ruby2ruby" "gauntlet"
    - The formar one causes dependency loop
    - The latter one is not found on Fedora (even on review request)
    Can this dependency (rather, this script) be ignored?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.