[Bug 542759] Review Request: mpqc - Ab-inito chemistry program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542759





--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-11-30 16:45:54 EDT ---
I'll have to take a look later on. I remember I had a look at mpqc some time
ago, but decided not to package it myself.

- Create the desktop file in %prep, not in %install.

- Is there any reason why you want to use macros for make and rm...?

- I think it would be better if the library package was just -libs.

- IMO the development package should be -devel, not libSC-devel.

- -data and -html should be BuildArch: noarch.

- -html should be called -doc.

- Drop Mandriva's obsoletes and provides. No need for them in Fedora.

- It's the Schrödinger equation, not Schrödinger...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.