[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #71 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info>  2009-10-01 03:29:47 EDT ---
(In reply to comment #70)
> I've reviewed the new spec file and the new src.rpm:
> 
> You've stated in the %changelog of the new spec file, that the following
> changes were done:
> - Own %%{_datadir}/%%{name} instead of %%{_datadir}/%%{name}/classes
> - Add Requires: %%{name} = %%{version}-%%{release} in subpackage.
> Unfortunately the fixes are not done in this spec file. Please can you verify,
> whether you've uploaded the wrong version of the spec file?
Sorry-sorry! Off course it is my mistake. I fix it (Note, without release
increase)

http://hubbitus.net.ru/rpm/Fedora11/x11vnc/x11vnc.spec


> Regarding the packaging of the GCJ AOT bits I've asked in #fedora-java whether
> it is really necessary in this specific case (jar files mostly used in a 
> browser on the client) and they've agreed that it is not needed here.
> 
> So once all changes are done which are stated in the spec file, I think all
> issues are solved. ;-)  
Fine!

Christian Krause, very thanks for that long and detailed review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.